Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 387343004: PrivateScriptRunner should use GetOwnPropertyDescriptor in V8 APIs (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

PrivateScriptRunner should use GetOwnPropertyDescriptor in V8 APIs This CL removes hand-written implementation for Object.getOwnPropertyDescriptor and instead uses a V8 API. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 3 chunks +12 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 5 months ago (2014-07-14 13:50:17 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-14 13:56:03 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-14 14:00:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/387343004/1
6 years, 5 months ago (2014-07-14 14:00:48 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 15:04:19 UTC) #5
Message was sent while issue was closed.
Change committed as 178064

Powered by Google App Engine
This is Rietveld 408576698