Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 387343003: Remove use of default SkPicture constructor (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
hal.canary, Torne, reed1
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove use of default SkPicture constructor Skia is removing the default SkPicture constructor. The only way to get an SkPicture will be through SkPictureRecorder, CreateFromStream, or CreateFromBuffer. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-14 13:50:09 UTC) #1
hal.canary
lgtm
6 years, 5 months ago (2014-07-14 13:56:30 UTC) #2
Torne
lgtm
6 years, 5 months ago (2014-07-14 16:16:28 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-14 16:19:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/387343003/1
6 years, 5 months ago (2014-07-14 16:20:04 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 18:22:13 UTC) #6
Message was sent while issue was closed.
Change committed as 282979

Powered by Google App Engine
This is Rietveld 408576698