Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 387343002: Fix up internalized strings after deserializing user code. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix up internalized strings after deserializing user code. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22398

Patch Set 1 #

Patch Set 2 : remove TODO #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -44 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/serialize.h View 3 chunks +7 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 7 chunks +56 lines, -7 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +63 lines, -10 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-14 12:56:04 UTC) #1
mvstanton
Hi Yang, LGTM. Just one comment regarding a safeguard for the feature on the association ...
6 years, 5 months ago (2014-07-14 13:31:03 UTC) #2
Yang
6 years, 5 months ago (2014-07-15 08:46:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698