Issue 387313011: HTMLMediaElement::updateActiveTextTrackCues(): use on-heap local vectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387313011: HTMLMediaElement::updateActiveTextTrackCues(): use on-heap local vectors (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, philipj_slow, nessy, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

HTMLMediaElement::updateActiveTextTrackCues(): use on-heap local vectors With Oilpan, use heap vectors to hold temporary references to other heap objects (text tracks and text track cues.) R=ager@chromium.org,haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178158

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/core/html/HTMLMediaElement.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/387313011/1

6 years, 5 months ago (2014-07-15 08:46:55 UTC) #5

Message was sent while issue was closed.

Change committed as 178158

Expand Messages | Collapse Messages