Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 387313007: Remove "ftp://ftp." prefix from the URL prefix list. (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
Reviewers:
Mark P
CC:
chromium-reviews
Visibility:
Public.

Description

Remove "ftp://ftp." prefix from the URL prefix list. This could lead to us inline-autocompleting "foo.com" for a previous typed visit to "ftp://ftp.foo.com", which feels misleading. We still have the "ftp://" and even "ftp://www." prefixes, so not all FTP URLs will be affected by this, just ones where the full hostname differs from the typed text by something other than a missing "www.". BUG=325997 TEST=Do a typed navigation to a valid "ftp://ftp.<something>" site. Start typing "<something>", verify the browser won't inline-autocomplete it; verify inline autocomplete works if you start typing "ftp.<something>". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/autocomplete/url_prefix.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Peter Kasting
6 years, 5 months ago (2014-07-15 00:37:25 UTC) #1
Mark P
Okay. lgtm. Do you have to revise any tests? --mark
6 years, 5 months ago (2014-07-15 18:17:52 UTC) #2
Peter Kasting
On 2014/07/15 18:17:52, Mark P wrote: > Okay. > > lgtm. > > Do you ...
6 years, 5 months ago (2014-07-15 18:29:08 UTC) #3
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 5 months ago (2014-07-15 18:29:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/387313007/1
6 years, 5 months ago (2014-07-15 18:33:07 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 02:59:28 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 03:22:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170972)
6 years, 5 months ago (2014-07-16 03:22:09 UTC) #8
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 5 months ago (2014-07-16 20:43:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/387313007/1
6 years, 5 months ago (2014-07-16 20:48:10 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:03:00 UTC) #11
Message was sent while issue was closed.
Change committed as 283498

Powered by Google App Engine
This is Rietveld 408576698