Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 387313005: views: Make the menu size the same as the menubutton size in the media bubble. (Closed)

Created:
6 years, 5 months ago by Elliot Glaysher
Modified:
6 years, 5 months ago
Reviewers:
msw, erg
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

views: Make the menu size the same as the menubutton size in the media bubble. This fixes the width in views mode; it doesn't fix it in GTK+ theme. Actually fixing that there is hard. BUG=393124 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283446

Patch Set 1 #

Patch Set 2 : Fixup #

Total comments: 2

Patch Set 3 : nits #

Patch Set 4 : Rebase to ToT; trybots are failing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -31 lines) Patch
M chrome/browser/ui/views/content_setting_bubble_contents.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 2 3 6 chunks +40 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
erg
6 years, 5 months ago (2014-07-15 00:32:58 UTC) #1
msw
lgtm with nits. I don't think this bug is a big deal, the menu certainly ...
6 years, 5 months ago (2014-07-15 02:46:38 UTC) #2
erg
The CQ bit was checked by erg@google.com
6 years, 5 months ago (2014-07-15 19:17:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/387313005/40001
6 years, 5 months ago (2014-07-15 19:20:54 UTC) #4
erg
The CQ bit was unchecked by erg@google.com
6 years, 5 months ago (2014-07-15 22:29:00 UTC) #5
erg
The CQ bit was checked by erg@google.com
6 years, 5 months ago (2014-07-15 22:29:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/387313005/60001
6 years, 5 months ago (2014-07-15 22:31:33 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 10:47:19 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:31:03 UTC) #9
Message was sent while issue was closed.
Change committed as 283446

Powered by Google App Engine
This is Rietveld 408576698