Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 387313003: update deep-memory-profiler policy for stlport (Closed)

Created:
6 years, 5 months ago by JungJik
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

update deep-memory-profiler policy for stlport 1. android uses stlport in ndk library, and this library does not have same demangled name with libc++ stl. so we can get rid of tc-std-* from android policies. 2. tc-stl-node and tc-stl-vector have same stackstrace. so I changed std-node to std-other to hook all other std mallocs. 3. tc-toplevel-string regex has changed. Bug=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284633

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebased(WebCore|blink) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -55 lines) Patch
M tools/deep_memory_profiler/policy.android.browser.json View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M tools/deep_memory_profiler/policy.android.renderer.json View 1 2 3 4 2 chunks +15 lines, -15 lines 0 comments Download
M tools/deep_memory_profiler/policy.android.webview.json View 1 2 3 4 4 chunks +3 lines, -33 lines 0 comments Download
M tools/deep_memory_profiler/policy.l2.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tools/deep_memory_profiler/policy.linux.browser.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/sorter.malloc-component.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
JungJik
Please take a look :)
6 years, 5 months ago (2014-07-15 12:38:21 UTC) #1
Dai Mikurube (NOT FULLTIME)
lgtm. Thanks!
6 years, 5 months ago (2014-07-16 05:59:19 UTC) #2
JungJik
On 2014/07/16 05:59:19, Dai Mikurube wrote: > lgtm. Thanks! thanks for lgtm. however I misunderstood ...
6 years, 5 months ago (2014-07-16 11:13:58 UTC) #3
JungJik
On 2014/07/16 11:13:58, JungJik wrote: > On 2014/07/16 05:59:19, Dai Mikurube wrote: > > lgtm. ...
6 years, 5 months ago (2014-07-18 11:32:07 UTC) #4
Dai Mikurube (NOT FULLTIME)
Still lgtm. Thanks!
6 years, 5 months ago (2014-07-22 02:56:33 UTC) #5
JungJik
On 2014/07/22 02:56:33, Dai Mikurube wrote: > Still lgtm. Thanks! Thanks for lgtm :). now ...
6 years, 5 months ago (2014-07-22 05:00:04 UTC) #6
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-22 05:00:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/387313003/60001
6 years, 5 months ago (2014-07-22 05:01:03 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 05:04:02 UTC) #9
commit-bot: I haz the power
Failed to apply patch for tools/deep_memory_profiler/policy.l2.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-22 05:04:03 UTC) #10
JungJik
On 2014/07/22 05:04:03, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 5 months ago (2014-07-22 05:27:40 UTC) #11
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-22 05:27:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/387313003/80001
6 years, 5 months ago (2014-07-22 05:28:56 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 05:30:06 UTC) #14
Message was sent while issue was closed.
Change committed as 284633

Powered by Google App Engine
This is Rietveld 408576698