Shrink isValidNameNonASCII by using U16_NEXT only once.

Shrink isValidNameNonASCII by using U16_NEXT only once.

This function was much larger than expected (314 bytes in gcc) and I think
it is because U16_NEXT is a large macro. Use it once instead of
twice.

Seems to have saved 144 bytes with gcc. U16_NEXT must be a crazily large macro:

  Shrunk symbols:
       -144: WebCore::Document::isValidName(WTF::String const&) type=t, (was 1253 bytes, now 1109 bytes)

74 bytes saved with clang:
 Shrunk symbols:
        -74: WebCore::Document::isValidName(WTF::String const&) type=t, (was 1190 bytes, now 1116 bytes)


BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182236

[Daniel Bratell, 2014-09-04 08:48:27]

bratell@opera.com changed reviewers:
+ eseidel@chromium.org

[fs, 2014-09-04 12:01:18]

lgtm

https://codereview.chromium.org/387313002/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/387313002/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:4108: for (unsigned i = 0; i < length;) {
Some might be alarmed by a for lacking an update expression - but I see
parseQualifiedNameInternal does it like this (and it's not mentioned in coding
style), so maybe it's ok...

Aside: Speaking of parseQualifiedName... that seems to be quite the beast as
well (almost 5k!). Sinking the exception/error-reporting out would probably put
a significant dent into that...

https://codereview.chromium.org/387313002/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:4109: bool first = i == 0;
I suppose this could also be:

bool nameStart = true;
for (...) {
    if (nameStart ? ...)
        ...;
    nameStart = false;
}

Hard to say what's better codegen-wise though...

[Daniel Bratell, 2014-09-18 11:46:00]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-09-18 11:46:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/387313002/1

[commit-bot: I haz the power, 2014-09-18 12:35:43]

Committed patchset #1 (id:1) as 182236