Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 387263003: Adopt unsigned long constant type into DOM (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adopt unsigned long constant type into DOM This CL made DOM understand unsigned long type what previously had been recognized as int. In addition, with this change, a failed test case will be passed in http://w3c-test.org/dom/traversal/NodeFilter-constants.html TEST=LayoutTests/fast/dom/constants.html Behavior in other browsers: *)FF: PASS *)IE: PASS Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M LayoutTests/fast/dom/constants.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/constants-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-14 03:59:15 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-14 04:23:13 UTC) #2
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-14 04:27:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/387263003/1
6 years, 5 months ago (2014-07-14 04:28:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-14 05:24:37 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 05:53:05 UTC) #6
Message was sent while issue was closed.
Change committed as 178025

Powered by Google App Engine
This is Rietveld 408576698