Issue 387253002: Revert "Revert of FileWriter should not use deprecated {,un}setPendingActivity (https://codereview.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387253002: Revert "Revert of FileWriter should not use deprecated {,un}setPendingActivity (https://codereview.… (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)

Modified:
6 years, 5 months ago

Reviewers:
haraken, nhiroki

CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Revert of FileWriter should not use deprecated {,un}setPendingActivity (https://codereview.chromium.org/383103002/)" This attempts to reland the patch with correct condition in |FileWriter::hasPendingActivity()|. Before this patch, it said m_readyState != WRITING then it "hasPendingActivity". Which is obviously opposite. TEST=fast/filesystem run with --enable-leak-detection does not leak BUG=354845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178021

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	Source/modules/filesystem/FileWriter.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/modules/filesystem/FileWriter.cpp	View		6 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/387253002/1

6 years, 5 months ago (2014-07-14 01:27:04 UTC) #4

Message was sent while issue was closed.

Change committed as 178021

Expand Messages | Collapse Messages