Introduce FullscreenElementStack::fullyExitFullscreen()

Introduce FullscreenElementStack::fullyExitFullscreen()

http://fullscreen.spec.whatwg.org/#fully-exit-fullscreen

BUG=383813
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178152

[philipj_slow, 2014-07-13 21:53:52]

PTAL

[eseidel, 2014-07-13 23:24:11]

What does it mean to only exitFullscreen not fullyExitFullscreen?

[philipj_slow, 2014-07-14 08:56:37]

On 2014/07/13 23:24:11, eseidel wrote:
> What does it mean to only exitFullscreen not fullyExitFullscreen?

"To fully exit fullscreen act as if the exitFullscreen() method was invoked on
the top-level browsing context's document and subsequently empty that document's
fullscreen element stack."

In other words, if you have a full-screen presentation that embeds a YouTube
iframe that itself goes fullscreen, there's difference between exitFullscreen
and fullyExitFullscreen for the iframe, namely that fully exiting fullscreen
would also exit the presentation.

There are cases in the code where I don't understand why webkitCancelFullScreen
(now fullyExitFullscreen) is used, like in HTMLMediaElement. However, in this
patch I've avoided making any observable changes.

[eseidel, 2014-07-14 22:15:11]

lgtm

ok

[commit-bot: I haz the power, 2014-07-14 22:15:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/387233002/1

[commit-bot: I haz the power, 2014-07-14 23:08:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/15398)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16842)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/32883)

[commit-bot: I haz the power, 2014-07-14 23:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-14 23:16:27]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[philipj_slow, 2014-07-15 07:03:14]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-07-15 07:04:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/387233002/1

[commit-bot: I haz the power, 2014-07-15 08:14:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16950)

[commit-bot: I haz the power, 2014-07-15 08:44:07]

Change committed as 178152