Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 387163002: Move Chrome OS pairing interface to chrome/browser/chromeos (Closed)

Created:
6 years, 5 months ago by Zachary Kuznia
Modified:
6 years, 5 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move Chrome OS pairing interface to chrome/browser/chromeos BUG=393413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284549

Patch Set 1 #

Patch Set 2 : Move to components/pairing #

Patch Set 3 : Move to components #

Patch Set 4 : Add missing file #

Total comments: 2

Patch Set 5 : Code review fixes #

Total comments: 8

Patch Set 6 : Code review fixes #

Patch Set 7 : Remove PAIRING_EXPORT #

Patch Set 8 : Rebase #

Patch Set 9 : Leave chromeos/pairing intact for try jobs #

Total comments: 2

Patch Set 10 : compoent -> source set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -1005 lines) Patch
M chrome/browser/chromeos/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.h View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.h View 1 2 3 4 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
D chromeos/pairing/controller_pairing_controller.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chromeos/pairing/controller_pairing_controller.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chromeos/pairing/fake_controller_pairing_controller.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chromeos/pairing/fake_controller_pairing_controller.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D chromeos/pairing/fake_host_pairing_controller.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chromeos/pairing/fake_host_pairing_controller.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D chromeos/pairing/host_pairing_controller.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chromeos/pairing/host_pairing_controller.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M components/components.gyp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A components/pairing.gypi View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
A components/pairing/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +21 lines, -0 lines 0 comments Download
A components/pairing/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + components/pairing/OWNERS View 1 2 3 4 5 6 7 8 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/pairing/controller_pairing_controller.h View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
A + components/pairing/controller_pairing_controller.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + components/pairing/fake_controller_pairing_controller.h View 1 2 3 4 5 6 3 chunks +7 lines, -8 lines 0 comments Download
A + components/pairing/fake_controller_pairing_controller.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A + components/pairing/fake_host_pairing_controller.h View 1 2 3 4 5 6 3 chunks +8 lines, -9 lines 0 comments Download
A + components/pairing/fake_host_pairing_controller.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A + components/pairing/host_pairing_controller.h View 1 2 3 4 5 6 2 chunks +6 lines, -7 lines 0 comments Download
A + components/pairing/host_pairing_controller.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Zachary Kuznia
Please take a look.
6 years, 5 months ago (2014-07-12 03:45:36 UTC) #1
chromium-reviews
Why it can't live in chromeos? 12 июля 2014 г. 7:45 пользователь <zork@chromium.org> написал: > ...
6 years, 5 months ago (2014-07-12 06:58:45 UTC) #2
dzhioev (left Google)
+1 On 2014/07/12 06:58:45, chromium-reviews wrote: > Why it can't live in chromeos? > 12 ...
6 years, 5 months ago (2014-07-14 12:14:24 UTC) #3
Nikita (slow)
> On 2014/07/12 06:58:45, chromium-reviews wrote: > > Why it can't live in chromeos? This ...
6 years, 5 months ago (2014-07-14 13:11:58 UTC) #4
Zachary Kuznia
On 2014/07/14 13:11:58, Nikita Kostylev wrote: > > On 2014/07/12 06:58:45, chromium-reviews wrote: > > ...
6 years, 5 months ago (2014-07-14 15:03:01 UTC) #5
Nikita (slow)
On 2014/07/14 15:03:01, Zachary Kuznia wrote: > On 2014/07/14 13:11:58, Nikita Kostylev wrote: > > ...
6 years, 5 months ago (2014-07-14 15:15:29 UTC) #6
stevenjb
On 2014/07/14 15:15:29, Nikita Kostylev wrote: > On 2014/07/14 15:03:01, Zachary Kuznia wrote: > > ...
6 years, 5 months ago (2014-07-14 16:51:29 UTC) #7
Zachary Kuznia
On 2014/07/14 16:51:29, stevenjb wrote: > On 2014/07/14 15:15:29, Nikita Kostylev wrote: > > On ...
6 years, 5 months ago (2014-07-15 22:36:33 UTC) #8
dzhioev (left Google)
On 2014/07/15 22:36:33, Zachary Kuznia wrote: > On 2014/07/14 16:51:29, stevenjb wrote: > > On ...
6 years, 5 months ago (2014-07-16 12:28:25 UTC) #9
Nikita (slow)
lgtm with nit https://codereview.chromium.org/387163002/diff/60001/components/components.gyp File components/components.gyp (right): https://codereview.chromium.org/387163002/diff/60001/components/components.gyp#newcode41 components/components.gyp:41: 'pairing.gypi', I think you need to ...
6 years, 5 months ago (2014-07-16 12:29:55 UTC) #10
stevenjb
The pairing code is still in the chromeos namespace, but I don't see any actual ...
6 years, 5 months ago (2014-07-16 17:56:49 UTC) #11
Zachary Kuznia
On 2014/07/16 17:56:49, stevenjb wrote: > The pairing code is still in the chromeos namespace, ...
6 years, 5 months ago (2014-07-16 18:01:15 UTC) #12
stevenjb
On 2014/07/16 18:01:15, Zachary Kuznia wrote: > On 2014/07/16 17:56:49, stevenjb wrote: > > The ...
6 years, 5 months ago (2014-07-16 18:19:49 UTC) #13
Zachary Kuznia
On 2014/07/16 18:19:49, stevenjb wrote: > On 2014/07/16 18:01:15, Zachary Kuznia wrote: > > On ...
6 years, 5 months ago (2014-07-16 20:22:14 UTC) #14
Zachary Kuznia
https://codereview.chromium.org/387163002/diff/60001/components/components.gyp File components/components.gyp (right): https://codereview.chromium.org/387163002/diff/60001/components/components.gyp#newcode41 components/components.gyp:41: 'pairing.gypi', On 2014/07/16 12:29:55, Nikita Kostylev wrote: > I ...
6 years, 5 months ago (2014-07-16 20:50:45 UTC) #15
Zachary Kuznia
jochen: Could you do an OWNERS review of: components/components.gyp components/pairing.gypi armansito: Could you do an ...
6 years, 5 months ago (2014-07-16 20:53:44 UTC) #16
stevenjb
On 2014/07/16 20:22:14, Zachary Kuznia wrote: > On 2014/07/16 18:19:49, stevenjb wrote: > > On ...
6 years, 5 months ago (2014-07-16 21:18:49 UTC) #17
armansito
components/pairing/DEPS lgtm
6 years, 5 months ago (2014-07-16 22:12:14 UTC) #18
jochen (gone - plz use gerrit)
https://codereview.chromium.org/387163002/diff/80001/components/pairing.gypi File components/pairing.gypi (right): https://codereview.chromium.org/387163002/diff/80001/components/pairing.gypi#newcode5 components/pairing.gypi:5: { can you also add a BUILD.gn version? https://codereview.chromium.org/387163002/diff/80001/components/pairing/DEPS ...
6 years, 5 months ago (2014-07-17 07:14:19 UTC) #19
Zachary Kuznia
https://codereview.chromium.org/387163002/diff/80001/components/pairing.gypi File components/pairing.gypi (right): https://codereview.chromium.org/387163002/diff/80001/components/pairing.gypi#newcode5 components/pairing.gypi:5: { On 2014/07/17 07:14:19, jochen wrote: > can you ...
6 years, 5 months ago (2014-07-17 22:14:47 UTC) #20
jochen (gone - plz use gerrit)
On 2014/07/17 at 22:14:47, zork wrote: > https://codereview.chromium.org/387163002/diff/80001/components/pairing/pairing_export.h > File components/pairing/pairing_export.h (right): > > https://codereview.chromium.org/387163002/diff/80001/components/pairing/pairing_export.h#newcode5 ...
6 years, 5 months ago (2014-07-18 09:18:00 UTC) #21
Zachary Kuznia
On 2014/07/18 09:18:00, jochen wrote: > On 2014/07/17 at 22:14:47, zork wrote: > > > ...
6 years, 5 months ago (2014-07-18 17:35:23 UTC) #22
jochen (gone - plz use gerrit)
lgtm with nit addressed https://codereview.chromium.org/387163002/diff/160001/components/pairing/BUILD.gn File components/pairing/BUILD.gn (right): https://codereview.chromium.org/387163002/diff/160001/components/pairing/BUILD.gn#newcode5 components/pairing/BUILD.gn:5: component("pairing") { should be source_set
6 years, 5 months ago (2014-07-21 11:25:43 UTC) #23
Zachary Kuznia
https://codereview.chromium.org/387163002/diff/160001/components/pairing/BUILD.gn File components/pairing/BUILD.gn (right): https://codereview.chromium.org/387163002/diff/160001/components/pairing/BUILD.gn#newcode5 components/pairing/BUILD.gn:5: component("pairing") { On 2014/07/21 11:25:42, jochen wrote: > should ...
6 years, 5 months ago (2014-07-21 17:27:39 UTC) #24
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 5 months ago (2014-07-21 17:48:28 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/387163002/180001
6 years, 5 months ago (2014-07-21 17:49:01 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 21:16:59 UTC) #27
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:17:44 UTC) #28
Message was sent while issue was closed.
Change committed as 284549

Powered by Google App Engine
This is Rietveld 408576698