src/IceTargetLoweringX8632.cpp - Issue 387153002: Fix floating point vector frem lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 387153002: Fix floating point vector frem lowering. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index f1b8c25097a151564c54f72d6190b7846d311cde..00e6f53226ac935d9092b5b6ba08fe9070e3891d 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -1182,9 +1182,10 @@ void TargetX8632::lowerArithmetic(const InstArithmetic *Inst) {

_movp(Dest, T);

} break;

case InstArithmetic::Frem: {

- const SizeT MaxSrcs = 1;

+ const SizeT MaxSrcs = 2;

InstCall *Call = makeHelperCall("__frem_v4f32", Dest, MaxSrcs);

Call->addArg(Src0);

+ Call->addArg(Src1);

lowerCall(Call);

} break;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »