Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 387153002: Fix floating point vector frem lowering. (Closed)

Created:
6 years, 5 months ago by wala
Modified:
6 years, 5 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Fix floating point vector frem lowering. The frem operation takes two arguments. Pass both Src0 and Src1 to __frem_v4f32. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0ecabc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/IceTargetLoweringX8632.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
wala
6 years, 5 months ago (2014-07-12 02:10:36 UTC) #1
Jim Stichnoth
lgtm
6 years, 5 months ago (2014-07-14 18:35:23 UTC) #2
wala
6 years, 5 months ago (2014-07-15 00:18:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r0ecabc8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698