Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.h

Issue 387123004: Revert 282726 "Reland "Use upstream libaddressinput in Chrome."" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.h
===================================================================
--- trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.h (revision 282731)
+++ trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.h (working copy)
@@ -11,7 +11,8 @@
#include "base/memory/scoped_vector.h"
#include "base/prefs/pref_store.h"
#include "base/scoped_observer.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/storage.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/scoped_ptr.h"
class WriteablePrefStore;
@@ -27,8 +28,9 @@
virtual ~ChromeStorageImpl();
// ::i18n::addressinput::Storage implementation.
- virtual void Put(const std::string& key, std::string* data) OVERRIDE;
- virtual void Get(const std::string& key, const Callback& data_ready)
+ virtual void Put(const std::string& key, scoped_ptr<std::string> data)
+ OVERRIDE;
+ virtual void Get(const std::string& key, scoped_ptr<Callback> data_ready)
const OVERRIDE;
// PrefStore::Observer implementation.
@@ -37,14 +39,14 @@
private:
struct Request {
- Request(const std::string& key, const Callback& callback);
+ Request(const std::string& key, scoped_ptr<Callback> callback);
std::string key;
- const Callback& callback;
+ scoped_ptr<Callback> callback;
};
// Non-const version of Get().
- void DoGet(const std::string& key, const Callback& data_ready);
+ void DoGet(const std::string& key, scoped_ptr<Callback> data_ready);
WriteablePrefStore* backing_store_; // weak

Powered by Google App Engine
This is Rietveld 408576698