Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: trunk/src/third_party/libaddressinput/chromium/addressinput_util.cc

Issue 387123004: Revert 282726 "Reland "Use upstream libaddressinput in Chrome."" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/third_party/libaddressinput/chromium/addressinput_util.cc
===================================================================
--- trunk/src/third_party/libaddressinput/chromium/addressinput_util.cc (revision 282731)
+++ trunk/src/third_party/libaddressinput/chromium/addressinput_util.cc (working copy)
@@ -8,8 +8,8 @@
#include "base/logging.h"
#include "base/macros.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_data.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_metadata.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_metadata.h"
namespace autofill {
namespace addressinput {
@@ -21,32 +21,32 @@
using ::i18n::addressinput::AddressProblem;
using ::i18n::addressinput::IsFieldRequired;
-using ::i18n::addressinput::MISSING_REQUIRED_FIELD;
-
// Returns true if the |problem| should not be reported for the |field| because
// the |filter| excludes it.
-bool FilterExcludes(const std::multimap<AddressField, AddressProblem>* filter,
- AddressField field,
- AddressProblem problem) {
+bool FilterExcludes(
+ const std::multimap<AddressField, AddressProblem::Type>* filter,
+ AddressField field,
+ AddressProblem::Type problem) {
return filter != NULL && !filter->empty() &&
- std::find(filter->begin(),
- filter->end(),
- std::multimap<AddressField, AddressProblem>::value_type(
- field, problem)) == filter->end();
+ std::find(
+ filter->begin(),
+ filter->end(),
+ std::multimap<AddressField, AddressProblem::Type>::value_type(
+ field, problem)) == filter->end();
}
} // namespace
bool HasAllRequiredFields(const AddressData& address_to_check) {
- std::multimap<AddressField, AddressProblem> problems;
+ std::multimap<AddressField, AddressProblem::Type> problems;
ValidateRequiredFields(address_to_check, NULL, &problems);
return problems.empty();
}
void ValidateRequiredFields(
const AddressData& address_to_check,
- const std::multimap<AddressField, AddressProblem>* filter,
- std::multimap<AddressField, AddressProblem>* problems) {
+ const std::multimap<AddressField, AddressProblem::Type>* filter,
+ std::multimap<AddressField, AddressProblem::Type>* problems) {
DCHECK(problems);
static const AddressField kFields[] = {
@@ -63,8 +63,10 @@
AddressField field = kFields[i];
if (address_to_check.IsFieldEmpty(field) &&
IsFieldRequired(field, address_to_check.region_code) &&
- !FilterExcludes(filter, field, MISSING_REQUIRED_FIELD)) {
- problems->insert(std::make_pair(field, MISSING_REQUIRED_FIELD));
+ !FilterExcludes(
+ filter, field, AddressProblem::MISSING_REQUIRED_FIELD)) {
+ problems->insert(
+ std::make_pair(field, AddressProblem::MISSING_REQUIRED_FIELD));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698