Remove kImageIsImmutable_Flag.

Remove kImageIsImmutable_Flag.

This flag was only used when setting or checking SkBitmap's
immutability when it did not have an SkPixelRef. Now that an
SkBitmap *must* have one in order to draw (e.g. you can no
longer have an SkBitmap that owns its pixels directly), its
immutabity without an SkPixelRef makes no sense.

Also, now that the flags are not contiguous starting from
0x01, use a more appropriate check to ensure only meaningful
flags are used.

Committed: https://skia.googlesource.com/skia/+/0847059fcffe11d53d4ea803ba2d51c696eb6d07

[scroggo, 2014-07-11 20:48:47]

https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp#newcod...
src/core/SkBitmap.cpp:1321: SkASSERT(fFlags <= allFlags);
We may want to update this to instead do a mask of all flags and make sure
fFlags can be masked out by the mask.

[scroggo, 2014-07-14 21:03:49]

ptal

https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp#newcod...
src/core/SkBitmap.cpp:1321: SkASSERT(fFlags <= allFlags);
On 2014/07/11 20:48:47, scroggo wrote:
> We may want to update this to instead do a mask of all flags and make sure
> fFlags can be masked out by the mask.

Done.

[reed1, 2014-07-15 19:04:25]

lgtm but what about flattening and format versions?

[scroggo, 2014-07-15 19:07:49]

We do not flatten fFlags.

[scroggo, 2014-07-15 19:07:53]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-07-15 19:08:45]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/scroggo@google.com/387083002/20001

[commit-bot: I haz the power, 2014-07-16 02:56:54]

Change committed as 0847059fcffe11d53d4ea803ba2d51c696eb6d07