Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 387083002: Remove kImageIsImmutable_Flag. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove kImageIsImmutable_Flag. This flag was only used when setting or checking SkBitmap's immutability when it did not have an SkPixelRef. Now that an SkBitmap *must* have one in order to draw (e.g. you can no longer have an SkBitmap that owns its pixels directly), its immutabity without an SkPixelRef makes no sense. Also, now that the flags are not contiguous starting from 0x01, use a more appropriate check to ensure only meaningful flags are used. Committed: https://skia.googlesource.com/skia/+/0847059fcffe11d53d4ea803ba2d51c696eb6d07

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + better validation for Flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M include/core/SkBitmap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scroggo
6 years, 5 months ago (2014-07-11 20:46:51 UTC) #1
scroggo
https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp#newcode1321 src/core/SkBitmap.cpp:1321: SkASSERT(fFlags <= allFlags); We may want to update this ...
6 years, 5 months ago (2014-07-11 20:48:47 UTC) #2
scroggo
ptal https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/387083002/diff/1/src/core/SkBitmap.cpp#newcode1321 src/core/SkBitmap.cpp:1321: SkASSERT(fFlags <= allFlags); On 2014/07/11 20:48:47, scroggo wrote: ...
6 years, 5 months ago (2014-07-14 21:03:49 UTC) #3
reed1
lgtm but what about flattening and format versions?
6 years, 5 months ago (2014-07-15 19:04:25 UTC) #4
scroggo
We do not flatten fFlags.
6 years, 5 months ago (2014-07-15 19:07:49 UTC) #5
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-15 19:07:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/387083002/20001
6 years, 5 months ago (2014-07-15 19:08:45 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 02:56:54 UTC) #8
Message was sent while issue was closed.
Change committed as 0847059fcffe11d53d4ea803ba2d51c696eb6d07

Powered by Google App Engine
This is Rietveld 408576698