Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 387073002: Print preview changes for App Kiosk mode. (Closed)

Created:
6 years, 5 months ago by Aleksey Shlyapnikov
Modified:
6 years, 5 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

In App Kiosk mode, Print Preview changes: - do not show user sign in promo - do not show cloud print dialog link - do not send COOKIES-based cloud printer search requests - do not add Save as PDF printer Related changes: - fix UI issues when no printer is selected - fix destination list sizing when one of the sections is empty BUG=370096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282800

Patch Set 1 #

Patch Set 2 : Fix PrintPreviewWebUITest.* #

Messages

Total messages: 8 (0 generated)
Aleksey Shlyapnikov
6 years, 5 months ago (2014-07-11 19:49:46 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 5 months ago (2014-07-11 21:05:21 UTC) #2
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 5 months ago (2014-07-11 21:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/387073002/1
6 years, 5 months ago (2014-07-11 21:16:02 UTC) #4
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 5 months ago (2014-07-11 23:29:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/387073002/20001
6 years, 5 months ago (2014-07-11 23:30:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 03:10:41 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 04:57:06 UTC) #8
Message was sent while issue was closed.
Change committed as 282800

Powered by Google App Engine
This is Rietveld 408576698