Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 387063002: Moves infrequently used debugger code in CheckInlineCachestub. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/stub_code_arm64.cc » ('j') | runtime/vm/stub_code_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
===================================================================
--- runtime/vm/stub_code_arm.cc (revision 38158)
+++ runtime/vm/stub_code_arm.cc (working copy)
@@ -1252,19 +1252,14 @@
}
#endif // DEBUG
+ Label stepping, done_stepping;
if (FLAG_enable_debugger) {
// Check single stepping.
- Label not_stepping;
__ ldr(R6, FieldAddress(CTX, Context::isolate_offset()));
__ ldrb(R6, Address(R6, Isolate::single_step_offset()));
__ CompareImmediate(R6, 0);
- __ b(&not_stepping, EQ);
- __ EnterStubFrame();
- __ Push(R5); // Preserve IC data.
- __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
- __ Pop(R5);
- __ LeaveStubFrame();
- __ Bind(&not_stepping);
+ __ b(&stepping, NE);
+ __ Bind(&done_stepping);
}
// Load arguments descriptor into R4.
@@ -1374,6 +1369,16 @@
__ ldr(R2, FieldAddress(R0, Function::instructions_offset()));
__ AddImmediate(R2, Instructions::HeaderSize() - kHeapObjectTag);
__ bx(R2);
+
+ if (FLAG_enable_debugger) {
+ __ Bind(&stepping);
+ __ EnterStubFrame();
+ __ Push(R5); // Preserve IC data.
+ __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
+ __ Pop(R5);
+ __ LeaveStubFrame();
+ __ b(&done_stepping);
+ }
}
« no previous file with comments | « no previous file | runtime/vm/stub_code_arm64.cc » ('j') | runtime/vm/stub_code_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698