Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: chrome/browser/gtk/view_id_util_browsertest.cc

Issue 387060: ViewIDTest.Basic fix (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/view_id_util_browsertest.cc
diff --git a/chrome/browser/gtk/view_id_util_browsertest.cc b/chrome/browser/gtk/view_id_util_browsertest.cc
index 907d0fb25b0103b2dc72ea07fcd650c6de661078..fe5060511837bdb55028598fcc215091e554e7bd 100644
--- a/chrome/browser/gtk/view_id_util_browsertest.cc
+++ b/chrome/browser/gtk/view_id_util_browsertest.cc
@@ -17,14 +17,19 @@ class ViewIDTest : public InProcessBrowserTest {
root_window_ = GTK_WIDGET(browser()->window()->GetNativeHandle());
ASSERT_TRUE(root_window_);
- EXPECT_EQ(should_have, !!ViewIDUtil::GetWidget(root_window_, id));
+ EXPECT_EQ(should_have, !!ViewIDUtil::GetWidget(root_window_, id))
+ << " Failed id=" << id;
}
private:
GtkWidget* root_window_;
};
-IN_PROC_BROWSER_TEST_F(ViewIDTest, DISABLED_Basic) {
+IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) {
+ // Make sure FindBar is created to test
+ // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE.
+ browser()->ShowFindBar();
+
for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
// http://crbug.com/21152
if (i == VIEW_ID_BOOKMARK_MENU)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698