Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/spellcheck_host.h

Issue 387055: Always destruct url request context getter on io thread.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_request_context_getter.h ('k') | chrome/browser/spellcheck_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellcheck_host.h
===================================================================
--- chrome/browser/spellcheck_host.h (revision 32112)
+++ chrome/browser/spellcheck_host.h (working copy)
@@ -64,6 +64,8 @@
// Executed on the file thread.
void InitializeInternal();
+ void InitializeOnFileThread();
+
// Inform |observer_| that initialization has finished.
void InformObserverOfInitialization();
@@ -82,6 +84,9 @@
const ResponseCookies& cookies,
const std::string& data);
+ // Saves |data_| to disk. Run on the file thread.
+ void SaveDictionaryData();
+
// May be NULL.
Observer* observer_;
@@ -104,9 +109,13 @@
// once.
bool tried_to_download_;
- // Used for downloading the dictionary file.
- scoped_refptr<URLRequestContextGetter> request_context_getter_;
+ // Data received from the dictionary download.
+ std::string data_;
+ // Used for downloading the dictionary file. We don't hold a reference, and
+ // it is only valid to use it on the UI thread.
+ URLRequestContextGetter* request_context_getter_;
+
// Used for downloading the dictionary file.
scoped_ptr<URLFetcher> fetcher_;
};
« no previous file with comments | « chrome/browser/net/url_request_context_getter.h ('k') | chrome/browser/spellcheck_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698