Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: runtime/bin/vmservice/vmservice.dart

Issue 38703009: Update VM service to new isolate API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/running_isolates.dart ('k') | runtime/bin/vmservice/vmservice_io.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/vmservice.dart
diff --git a/runtime/bin/vmservice/vmservice.dart b/runtime/bin/vmservice/vmservice.dart
index 83c21685dbf11a9e7237d7ae988c62392f5801be..9c58842fe0186973c8db820d9d1e087787b19499 100644
--- a/runtime/bin/vmservice/vmservice.dart
+++ b/runtime/bin/vmservice/vmservice.dart
@@ -5,7 +5,7 @@
library vmservice;
import 'dart:async';
-import "dart:convert";
+import 'dart:convert';
import 'dart:isolate';
import 'dart:typed_data';
@@ -19,26 +19,29 @@ part 'service_request_router.dart';
class VMService {
static VMService _instance;
RunningIsolates runningIsolates = new RunningIsolates();
+ final RawReceivePort receivePort;
- void controlMessageHandler(int code, SendPort sp, String name) {
+ void controlMessageHandler(int code, int port_id, SendPort sp, String name) {
switch (code) {
case Constants.ISOLATE_STARTUP_MESSAGE_ID:
- runningIsolates.isolateStartup(sp, name);
+ runningIsolates.isolateStartup(port_id, sp, name);
break;
case Constants.ISOLATE_SHUTDOWN_MESSAGE_ID:
- runningIsolates.isolateShutdown(sp);
+ runningIsolates.isolateShutdown(port_id, sp);
break;
}
}
void messageHandler(message) {
- if (message is List && message.length == 3) {
- controlMessageHandler(message[0], message[1], message[2]);
+ assert(message is List);
+ assert(message.length == 4);
+ if (message is List && message.length == 4) {
+ controlMessageHandler(message[0], message[1], message[2], message[3]);
}
}
- VMService._internal() {
- port.listen(messageHandler);
+ VMService._internal() : receivePort = new RawReceivePort() {
+ receivePort.handler = messageHandler;
}
factory VMService() {
« no previous file with comments | « runtime/bin/vmservice/running_isolates.dart ('k') | runtime/bin/vmservice/vmservice_io.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698