Update VM service to new isolate API

runtime/bin/vmservice_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/vmservice_impl.h"
 
 #include "include/dart_api.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
@@ skipping 123 matching lines @@
     Dart_ShutdownIsolate();
     error_msg_ = "Invalid isolate state - Unable to make it runnable.";
     return false;
   }
 
   Dart_EnterIsolate(isolate_);
   Dart_EnterScope();
 
 
   Dart_Handle library = Dart_RootLibrary();
-  // Set requested port.
+  // Set requested TCP port.
   DartUtils::SetIntegerField(library, "_port", server_port);
   result = Dart_Invoke(library, DartUtils::NewString("main"), 0, NULL);
   SHUTDOWN_ON_ERROR(result);
+  // Retrieve the ReceivePort that the service is waiting on. The _receivePort
+  // variable is setup in the call to main.
+  Dart_Handle receivePort = Dart_GetField(library,

[Ivan Posva, 2013/10/25 00:30:27]

I generally find this mix of external C API and internal VM functions confusing
and concerning. What is the functionality that was not available from the
external API?

[Cutch, 2013/10/25 01:21:57]

The external API does not offer functionality to map from a ReceivePort or
SendPort to a Dart_Port.

+                                          DartUtils::NewString("_receivePort"));
+  SHUTDOWN_ON_ERROR(receivePort);
+
+  {
+    // Extract the Dart_Port from the receive port.
+    HANDLESCOPE(Isolate::Current());
+    const Object& unwrapped_rp = Object::Handle(Api::UnwrapHandle(receivePort));
+    const Instance& rp = Instance::Cast(unwrapped_rp);
+    // Extract ReceivePort port id.
+    const Object& rp_id_obj = Object::Handle(DartLibraryCalls::PortGetId(rp));
+    if (rp_id_obj.IsError()) {
+      const Error& error = Error::Cast(rp_id_obj);
+      error_msg_ = strdup(error.ToErrorCString());
+      Dart_ExitScope();
+      Dart_ShutdownIsolate();
+      return false;
+    }
+    ASSERT(rp_id_obj.IsSmi() || rp_id_obj.IsMint());
+    Integer& id = Integer::Handle();
+    id ^= rp_id_obj.raw();
+    port_ = static_cast<Dart_Port>(id.AsInt64Value());
+  }
+
 
   Dart_Handle library_name = Dart_NewStringFromCString(kVMServiceLibraryName);
   library = Dart_LookupLibrary(library_name);
   SHUTDOWN_ON_ERROR(library);
   result = LoadResources(library);
   SHUTDOWN_ON_ERROR(result);
   result = Dart_CompileAll();

[Ivan Posva, 2013/10/25 00:30:27]

Please remove this or at least make it optional based on a flag.

[Cutch, 2013/10/25 01:21:57]

Done.

   SHUTDOWN_ON_ERROR(result);
 
-  port_ = Dart_GetMainPortId();
-
   Dart_ExitScope();
   Dart_ExitIsolate();
 
   return true;
 }
 
 
 void VmService::_Stop() {
   port_ = ILLEGAL_PORT;
 }
@@ skipping 230 matching lines @@
   result = Dart_ListSetAt(list, 0, codeHandle);
   ASSERT(!Dart_IsError(result));
   Dart_Handle sendPort = Dart_NewSendPort(port);
   ASSERT(!Dart_IsError(sendPort));
   result = Dart_ListSetAt(list, 1, sendPort);
   ASSERT(!Dart_IsError(result));
   return list;
 }
 
 
-bool VmService::SendIsolateStartupMessage(Dart_Port port, Dart_Handle name) {
+bool VmService::SendIsolateStartupMessage() {
   if (!IsRunning()) {
     return false;
   }
-  Dart_Isolate isolate = Dart_CurrentIsolate();
+  Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
-  ASSERT(Dart_GetMainPortId() == port);
+  StackZone zone(isolate);

[Ivan Posva, 2013/10/25 00:30:27]

ditto.

[Cutch, 2013/10/25 01:21:57]

Done.

+  HANDLESCOPE(isolate);
+  Dart_Port service_port = isolate->service_port();
   Dart_Handle list =
-      MakeServiceControlMessage(port, VM_SERVICE_ISOLATE_STARTUP_MESSAGE_ID);
+      MakeServiceControlMessage(service_port,
+                                VM_SERVICE_ISOLATE_STARTUP_MESSAGE_ID);
   ASSERT(!Dart_IsError(list));
+  Dart_Handle name = Api::NewHandle(isolate, String::New(isolate->name()));
   Dart_Handle result = Dart_ListSetAt(list, 2, name);
   ASSERT(!Dart_IsError(result));
   return Dart_Post(port_, list);
 }
 
 
-bool VmService::SendIsolateShutdownMessage(Dart_Port port) {
+bool VmService::SendIsolateShutdownMessage() {
   if (!IsRunning()) {
     return false;
   }
-  Dart_Isolate isolate = Dart_CurrentIsolate();
+  Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
-  ASSERT(Dart_GetMainPortId() == port);
+  StackZone zone(isolate);
+  HANDLESCOPE(isolate);
+  Dart_Port service_port = isolate->service_port();
   Dart_Handle list =
-      MakeServiceControlMessage(port, VM_SERVICE_ISOLATE_SHUTDOWN_MESSAGE_ID);
+      MakeServiceControlMessage(service_port,
+                                VM_SERVICE_ISOLATE_SHUTDOWN_MESSAGE_ID);
   ASSERT(!Dart_IsError(list));
   return Dart_Post(port_, list);
 }
 
 
 void VmService::VmServiceShutdownCallback(void* callback_data) {
   ASSERT(Dart_CurrentIsolate() != NULL);
   Dart_EnterScope();
-  VmService::SendIsolateShutdownMessage(Dart_GetMainPortId());
+  VmService::SendIsolateShutdownMessage();
   Dart_ExitScope();
 }
 
 
 static uint8_t* allocator(uint8_t* ptr, intptr_t old_size, intptr_t new_size) {
   void* new_ptr = realloc(reinterpret_cast<void*>(ptr), new_size);
   return reinterpret_cast<uint8_t*>(new_ptr);
 }
 
 
@@ skipping 66 matching lines @@
     if (!strcmp(function_name, entry.name) &&
         (num_arguments == entry.num_arguments)) {
       return entry.function;
     }
   }
   return NULL;
 }
 
 }  // namespace bin
 }  // namespace dart