Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/IceTranslator.h

Issue 387023002: Clean up exit status and globals procecessing in llvm2ice. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Change ExitStatus to ErrorStatus. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceConverter.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTranslator.h
diff --git a/src/IceTranslator.h b/src/IceTranslator.h
index 648faeaf5f71369b98431700343e832358133a8f..11899513e415337d0b1b01a53747dfa9668093e3 100644
--- a/src/IceTranslator.h
+++ b/src/IceTranslator.h
@@ -30,17 +30,17 @@ class GlobalContext;
class Translator {
public:
Translator(GlobalContext *Ctx, ClFlags &Flags)
- : Ctx(Ctx), Flags(Flags), ExitStatus(0) {}
+ : Ctx(Ctx), Flags(Flags), ErrorStatus(0) {}
~Translator();
- int getExitStatus() const { return ExitStatus; }
+ bool getErrorStatus() const { return ErrorStatus; }
protected:
GlobalContext *Ctx;
ClFlags &Flags;
- // The exit status of the translation. 0 is successful. Nonzero
+ // The exit status of the translation. False is successful. True
// otherwise.
- int ExitStatus;
+ bool ErrorStatus;
// Ideally, Func would be inside the methods that converts IR to
// functions. However, emitting the constant pool requires a valid
// Cfg object, so we need to defer deleting the last non-empty Cfg
« no previous file with comments | « src/IceConverter.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698