Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: src/IceConverter.h

Issue 387023002: Clean up exit status and globals procecessing in llvm2ice. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Change ExitStatus to ErrorStatus. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceConverter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceConverter.h
diff --git a/src/IceConverter.h b/src/IceConverter.h
index dc18e7a09838e9b6feca9cf0ba8dee1bb4c35b2e..30d3b6041c4d8e859d6fa2e0351b4c5b135273d1 100644
--- a/src/IceConverter.h
+++ b/src/IceConverter.h
@@ -25,11 +25,15 @@ namespace Ice {
class Converter : public Translator {
public:
Converter(GlobalContext *Ctx, Ice::ClFlags &Flags) : Translator(Ctx, Flags) {}
- /// Converts the LLVM Module to ICE. Returns exit status 0 if successful,
- /// Nonzero otherwise.
- int convertToIce(llvm::Module *Mod);
+ /// Converts the LLVM Module to ICE. Sets exit status to false if successful,
+ /// true otherwise.
+ void convertToIce(llvm::Module *Mod);
private:
+ // Converts globals to ICE, and then machine code.
+ void convertGlobals(llvm::Module *Mod);
+ // Converts functions to ICE, and then machine code.
+ void convertFunctions(llvm::Module *Mod);
Converter(const Converter &) LLVM_DELETED_FUNCTION;
Converter &operator=(const Converter &) LLVM_DELETED_FUNCTION;
};
« no previous file with comments | « no previous file | src/IceConverter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698