Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/IceTranslator.h

Issue 387023002: Clean up exit status and globals procecessing in llvm2ice. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Change ExitStatus to ErrorStatus. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceConverter.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceTranslator.h - ICE to machine code --------*- C++ -*-===// 1 //===- subzero/src/IceTranslator.h - ICE to machine code --------*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the general driver class for translating ICE to 10 // This file declares the general driver class for translating ICE to
(...skipping 12 matching lines...) Expand all
23 class Cfg; 23 class Cfg;
24 class GlobalContext; 24 class GlobalContext;
25 25
26 // Base class for translating ICE to machine code. 26 // Base class for translating ICE to machine code.
27 // Derived classes convert other intermediate representations down to ICE, 27 // Derived classes convert other intermediate representations down to ICE,
28 // and then call the appropriate (inherited) methods to convert ICE into 28 // and then call the appropriate (inherited) methods to convert ICE into
29 // machine instructions. 29 // machine instructions.
30 class Translator { 30 class Translator {
31 public: 31 public:
32 Translator(GlobalContext *Ctx, ClFlags &Flags) 32 Translator(GlobalContext *Ctx, ClFlags &Flags)
33 : Ctx(Ctx), Flags(Flags), ExitStatus(0) {} 33 : Ctx(Ctx), Flags(Flags), ErrorStatus(0) {}
34 34
35 ~Translator(); 35 ~Translator();
36 int getExitStatus() const { return ExitStatus; } 36 bool getErrorStatus() const { return ErrorStatus; }
37 37
38 protected: 38 protected:
39 GlobalContext *Ctx; 39 GlobalContext *Ctx;
40 ClFlags &Flags; 40 ClFlags &Flags;
41 // The exit status of the translation. 0 is successful. Nonzero 41 // The exit status of the translation. False is successful. True
42 // otherwise. 42 // otherwise.
43 int ExitStatus; 43 bool ErrorStatus;
44 // Ideally, Func would be inside the methods that converts IR to 44 // Ideally, Func would be inside the methods that converts IR to
45 // functions. However, emitting the constant pool requires a valid 45 // functions. However, emitting the constant pool requires a valid
46 // Cfg object, so we need to defer deleting the last non-empty Cfg 46 // Cfg object, so we need to defer deleting the last non-empty Cfg
47 // object to emit the constant pool (via emitConstants). TODO: 47 // object to emit the constant pool (via emitConstants). TODO:
48 // Since all constants are globally pooled in the GlobalContext 48 // Since all constants are globally pooled in the GlobalContext
49 // object, change all Constant related functions to use 49 // object, change all Constant related functions to use
50 // GlobalContext instead of Cfg, and then make emitConstantPool use 50 // GlobalContext instead of Cfg, and then make emitConstantPool use
51 // that. 51 // that.
52 llvm::OwningPtr<Cfg> Func; 52 llvm::OwningPtr<Cfg> Func;
53 53
54 /// Translates the constructed ICE function Fcn to machine code. 54 /// Translates the constructed ICE function Fcn to machine code.
55 /// Note: As a side effect, Field Func is set to Fcn. 55 /// Note: As a side effect, Field Func is set to Fcn.
56 void translateFcn(Cfg *Fcn); 56 void translateFcn(Cfg *Fcn);
57 57
58 /// Emits the constant pool. 58 /// Emits the constant pool.
59 void emitConstants(); 59 void emitConstants();
60 60
61 private: 61 private:
62 Translator(const Translator &) LLVM_DELETED_FUNCTION; 62 Translator(const Translator &) LLVM_DELETED_FUNCTION;
63 Translator &operator=(const Translator &) LLVM_DELETED_FUNCTION; 63 Translator &operator=(const Translator &) LLVM_DELETED_FUNCTION;
64 }; 64 };
65 } 65 }
66 66
67 #endif // SUBZERO_SRC_ICETRANSLATOR_H 67 #endif // SUBZERO_SRC_ICETRANSLATOR_H
OLDNEW
« no previous file with comments | « src/IceConverter.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698