Http Cache: Split HttpCache::Transaction to its own set...

Http Cache: Split HttpCache::Transaction to its own set
of files.

No real code change... I'm just moving code around.

BUG=26729
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31693

[rvargas (doing something else), 2009-11-11 01:57:13]

Reviewers: eroman,

Description:
Http Cache: Split HttpCache::Transaction to its own set
of files.

No real code change... I'm just moving code around.

BUG=26729
TEST=none


Please review this at http://codereview.chromium.org/387017

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     net/http/http_cache.cc
   A  +  net/http/http_cache_transaction.h
   A  +  net/http/http_cache_transaction.cc
   M     net/net.gyp

[rvargas (doing something else), 2009-11-11 02:02:47]

http://codereview.chromium.org/387017/diff/1/5
File net/http/http_cache_transaction.h (right):

http://codereview.chromium.org/387017/diff/1/5#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
Year already fixed.

[eroman, 2009-11-11 03:56:35]

LGTM

http://codereview.chromium.org/387017/diff/1/5
File net/http/http_cache_transaction.h (right):

http://codereview.chromium.org/387017/diff/1/5#newcode87
Line 87: static const size_t kNumValidationHeaders = 2;
nit: i believe the struct declaration should precede the constant.

[eroman, 2009-11-11 03:56:54]

LGTM


http://codereview.chromium.org/387017/diff/1/5
File net/http/http_cache_transaction.h (right):

http://codereview.chromium.org/387017/diff/1/5#newcode87
Line 87: static const size_t kNumValidationHeaders = 2;
nit: i believe the struct declaration should precede the constant.

http://codereview.chromium.org/387017

[rvargas (doing something else), 2009-11-11 04:01:19]

Thanks


http://codereview.chromium.org/387017/diff/1/5
File net/http/http_cache_transaction.h (right):

http://codereview.chromium.org/387017/diff/1/5#newcode87
Line 87: static const size_t kNumValidationHeaders = 2;
On 2009/11/11 03:56:35, eroman wrote:
> nit: i believe the struct declaration should precede the constant.

That makes sense, but I need the constant to define the struct.

http://codereview.chromium.org/387017

[eroman, 2009-11-11 04:06:02]

> That makes sense, but I need the constant to define the struct.

Oh right.

LGTM

[eroman, 2009-11-11 04:06:20]

> That makes sense, but I need the constant to define the struct.

Oh right.

LGTM

http://codereview.chromium.org/387017

[darin (slow to review), 2009-11-16 22:22:31]

yay!  really glad to see this.  sorry for not doing so originally :)

-darin


On Tue, Nov 10, 2009 at 5:56 PM, <rvargas@chromium.org> wrote:

> Reviewers: eroman,
>
> Description:
> Http Cache: Split HttpCache::Transaction to its own set
> of files.
>
> No real code change... I'm just moving code around.
>
> BUG=26729
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/387017
>
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     net/http/http_cache.cc
>  A  +  net/http/http_cache_transaction.h
>  A  +  net/http/http_cache_transaction.cc
>  M     net/net.gyp
>
>
>