Detect when first_party_for_cookies_ needs to be updated on redirect....

Detect when first_party_for_cookies_ needs to be updated on redirect.

R=abarth
BUG=25133
TEST=In Options menu, change cookie policy to "Accept cookies only from
sites I visit" and then follow the instructions in issue 25133 comment 20.

[wtc, 2009-11-10 22:05:33]

The problem is that when a main frame is redirected, WebKit
updates "first party for cookies", but this change is not
propagated through the resource dispatcher host to the
network stack.

This patch is a solution where the network stack can locally
detect that "first party for cookies" will be wrong after
following a redirect.  It doesn't require receiving an
"update first party for cookies" command from WebKit.

[wtc, 2009-11-10 22:05:51]

Reviewers: abarth,

Message:
The problem is that when a main frame is redirected, WebKit
updates "first party for cookies", but this change is not
propagated through the resource dispatcher host to the
network stack.

This patch is a solution where the network stack can locally
detect that "first party for cookies" will be wrong after
following a redirect.  It doesn't require receiving an
"update first party for cookies" command from WebKit.

Description:
Detect when first_party_for_cookies_ needs to be updated on redirect.

R=abarth
BUG=25133
TEST=In Options menu, change cookie policy to "Accept cookies only from
sites I visit" and then follow the instructions in issue 25133 comment 20.

Please review this at http://codereview.chromium.org/387013

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     net/url_request/url_request.cc


Index: net/url_request/url_request.cc
===================================================================
--- net/url_request/url_request.cc	(revision 31201)
+++ net/url_request/url_request.cc	(working copy)
@@ -457,6 +457,9 @@
      method_ = "GET";
      upload_ = NULL;
    }
+  // If first_party_for_cookies_ is redirected, update it to the new  
location.
+  if (first_party_for_cookies_ == url_)
+    first_party_for_cookies_ = location;
    url_ = location;
    --redirect_limit_;

[abarth-chromium, 2009-11-10 22:12:29]

We need an automated test for this.  It's too subtle to test manually.

[abarth-chromium, 2009-11-10 22:12:49]

We need an automated test for this.  It's too subtle to test manually.

http://codereview.chromium.org/387013

[abarth-chromium, 2009-11-10 22:13:36]

This should be testable using a LayoutTest, btw.

[abarth-chromium, 2009-11-10 22:13:55]

This should be testable using a LayoutTest, btw.

http://codereview.chromium.org/387013

[wtc, 2009-11-11 23:02:25]

I spoke to eroman about this bug, and he agrees that the
other solution at http://codereview.chromium.org/385024
is better, so I abandoned this CL.