Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 387013: Detect when first_party_for_cookies_ needs to be updated on redirect.... (Closed)

Created:
11 years, 1 month ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews_googlegroups.com, darin (slow to review), eroman
Visibility:
Public.

Description

Detect when first_party_for_cookies_ needs to be updated on redirect. R=abarth BUG=25133 TEST=In Options menu, change cookie policy to "Accept cookies only from sites I visit" and then follow the instructions in issue 25133 comment 20.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/url_request/url_request.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wtc
The problem is that when a main frame is redirected, WebKit updates "first party for ...
11 years, 1 month ago (2009-11-10 22:05:33 UTC) #1
wtc
Reviewers: abarth, Message: The problem is that when a main frame is redirected, WebKit updates ...
11 years, 1 month ago (2009-11-10 22:05:51 UTC) #2
abarth-chromium
We need an automated test for this. It's too subtle to test manually.
11 years, 1 month ago (2009-11-10 22:12:29 UTC) #3
abarth-chromium
We need an automated test for this. It's too subtle to test manually. http://codereview.chromium.org/387013
11 years, 1 month ago (2009-11-10 22:12:49 UTC) #4
abarth-chromium
This should be testable using a LayoutTest, btw.
11 years, 1 month ago (2009-11-10 22:13:36 UTC) #5
abarth-chromium
This should be testable using a LayoutTest, btw. http://codereview.chromium.org/387013
11 years, 1 month ago (2009-11-10 22:13:55 UTC) #6
wtc
11 years, 1 month ago (2009-11-11 23:02:25 UTC) #7
I spoke to eroman about this bug, and he agrees that the
other solution at http://codereview.chromium.org/385024
is better, so I abandoned this CL.

Powered by Google App Engine
This is Rietveld 408576698