editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java - Issue 387003003: Generate compile errors for illegal uses of const Symbol constructor.

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

Issue 387003003: Generate compile errors for illegal uses of const Symbol constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantValueComputer.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

index 9ad1cba04b6c3d3841c3d754a21410a3599b746f..13bff77f719163bd2efdf046a828b76f02b0b45c 100644

--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/constant/ConstantValueComputerTest.java

@@ -725,6 +725,30 @@ public class ConstantValueComputerTest extends ResolverTestCase {

assertFalse(c_int_value.equals(c_num_value));

}

+ public void test_isValidSymbol() {

+ assertTrue(ConstantValueComputer.isValidPublicSymbol(""));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo.bar"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo$"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo$bar"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("iff"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("gif"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("if$"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("$if"));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo="));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo.bar="));

+ assertTrue(ConstantValueComputer.isValidPublicSymbol("foo.+"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("_foo"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("_foo.bar"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("foo._bar"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("if"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("if.foo"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("foo.if"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("foo=.bar"));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("foo."));

+ assertFalse(ConstantValueComputer.isValidPublicSymbol("+.foo"));

+ }

private HashMap<String, DartObjectImpl> assertFieldType(HashMap<String, DartObjectImpl> fields,

String fieldName, String expectedType) {

DartObjectImpl field = fields.get(fieldName);