Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: tools/perf/benchmarks/dom_perf.py

Issue 387003002: Update dom_perf to use results.AddValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/dom_perf.py
diff --git a/tools/perf/benchmarks/dom_perf.py b/tools/perf/benchmarks/dom_perf.py
index b16047aa9c4f1b774d2d5dfca31072b587360d15..afb98e633a894980a384f067fad34d6712af684b 100644
--- a/tools/perf/benchmarks/dom_perf.py
+++ b/tools/perf/benchmarks/dom_perf.py
@@ -52,8 +52,9 @@ class _DomPerfMeasurement(page_measurement.PageMeasurement):
for suite in data['BenchmarkSuites']:
# Skip benchmarks that we didn't actually run this time around.
if len(suite['Benchmarks']) or suite['score']:
- results.Add(SCORE_TRACE_NAME, SCORE_UNIT,
- suite['score'], suite['name'], 'unimportant')
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, '%s.%s' % (suite['name'], SCORE_TRACE_NAME),
+ SCORE_UNIT, suite['score'], important=False))
finally:
tab.EvaluateJavaScript('document.cookie = "__domperf_finished=0"')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698