Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 387002: Implement EventSender.mouseWheelTo method.... (Closed)

Created:
11 years, 1 month ago by kinuko (google)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Implement EventSender.mouseWheelTo method. WebKit fix is also needed to make the test pass. http://bugs.webkit.org/show_bug.cgi?id=31292 BUG=24175 TEST=LayoutTests/platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 1 2 3 4 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinuko (google)
11 years, 1 month ago (2009-11-11 03:33:33 UTC) #1
kinuko (google)
Reviewers: levin, Evan Martin, Evan Stade, Description: Implement EventSender.mouseWheelTo method. WebKit fix is also needed ...
11 years, 1 month ago (2009-11-11 03:33:57 UTC) #2
Evan Martin
LGTM http://codereview.chromium.org/387002/diff/3001/6 File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/387002/diff/3001/6#newcode418 Line 418: webview()->layout(); why is this layout necessary? maybe ...
11 years, 1 month ago (2009-11-11 08:08:11 UTC) #3
Evan Martin
LGTM http://codereview.chromium.org/387002/diff/3001/6 File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/387002/diff/3001/6#newcode418 Line 418: webview()->layout(); why is this layout necessary? maybe ...
11 years, 1 month ago (2009-11-11 08:08:30 UTC) #4
kinuko (google)
On 2009/11/11 08:08:30, Evan Martin wrote: > LGTM > > > http://codereview.chromium.org/387002/diff/3001/6 > File webkit/tools/test_shell/event_sending_controller.cc ...
11 years, 1 month ago (2009-11-11 10:49:18 UTC) #5
kinuko (google)
On 2009/11/11 08:08:30, Evan Martin wrote: > LGTM > http://codereview.chromium.org/387002/diff/3001/6 > File webkit/tools/test_shell/event_sending_controller.cc (right): > ...
11 years, 1 month ago (2009-11-11 10:49:40 UTC) #6
kinuko (google)
Updated the test_expectations.txt too as upstream patch has been landed. Is it OK to submit? ...
11 years, 1 month ago (2009-11-16 06:31:19 UTC) #7
Evan Martin
LGTM, minor English suggestions follow http://codereview.chromium.org/387002/diff/7001/9 File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/387002/diff/7001/9#newcode417 Line 417: // Forces a ...
11 years, 1 month ago (2009-11-16 08:15:48 UTC) #8
kinuko (google)
Thanks for reviewing! I've corrected the comment. On 2009/11/16 08:15:48, Evan Martin wrote: > LGTM, ...
11 years, 1 month ago (2009-11-16 08:28:15 UTC) #9
tkent
11 years, 1 month ago (2009-11-17 06:07:06 UTC) #10
Committed as r32157.

Powered by Google App Engine
This is Rietveld 408576698