Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java

Issue 386983002: Correct the usage of finalize in TracingControllerAndroid class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java b/content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
index 8f98189ed249011ea48085e84019557473195061..6d70844f858f6af3ed171366939a5ddd5ccd9018 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
@@ -61,5 +61,9 @@ public class TracingControllerAndroidTest extends ContentShellTestBase {
// It says it stopped, so it should have written the output file.
assertTrue(file.exists());
assertTrue(file.delete());
+ // destroy native tracing controller objects.
Sami 2014/07/14 09:46:49 nit: This comment could be removed.
wajahat 2014/07/14 10:04:13 Done.
+ if (!tracingController.isTracing()) {
Sami 2014/07/14 09:46:49 No need for this check because of the while-loop a
wajahat 2014/07/14 10:04:13 Done.
+ tracingController.destroy();
+ }
}
}
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698