Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 386963006: [Telemetry] Suppress red-herring error messages. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Suppress red-herring error messages. These confuse sheriffs in the log because they are harmless and just mean that the browser closed the connection to the webserver aburptly. WPR has the same logic here: https://github.com/chromium/web-page-replay/blob/master/httpproxy.py This eliminates this stack: Traceback (most recent call last): File "/usr/lib/python2.7/SocketServer.py", line 593, in process_request_thread self.finish_request(request, client_address) File "/usr/lib/python2.7/SocketServer.py", line 334, in finish_request self.RequestHandlerClass(request, client_address, self) File "/usr/lib/python2.7/SocketServer.py", line 649, in __init__ self.handle() File "/usr/lib/python2.7/BaseHTTPServer.py", line 342, in handle self.handle_one_request() File "/usr/lib/python2.7/BaseHTTPServer.py", line 310, in handle_one_request self.raw_requestline = self.rfile.readline(65537) File "/usr/lib/python2.7/socket.py", line 476, in readline data = self._sock.recv(self._rbufsize) error: [Errno 104] Connection reset by peer BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290948

Patch Set 1 #

Total comments: 2

Patch Set 2 : don't duplicate code #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/memory_cache_http_server.py View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
tonyg
https://codereview.chromium.org/386963006/diff/1/tools/telemetry/telemetry/core/memory_cache_http_server.py File tools/telemetry/telemetry/core/memory_cache_http_server.py (right): https://codereview.chromium.org/386963006/diff/1/tools/telemetry/telemetry/core/memory_cache_http_server.py#newcode31 tools/telemetry/telemetry/core/memory_cache_http_server.py:31: def handle(self): This is a copy from BaseHTTPServer with ...
6 years, 5 months ago (2014-07-11 20:12:58 UTC) #1
dtu
https://codereview.chromium.org/386963006/diff/1/tools/telemetry/telemetry/core/memory_cache_http_server.py File tools/telemetry/telemetry/core/memory_cache_http_server.py (right): https://codereview.chromium.org/386963006/diff/1/tools/telemetry/telemetry/core/memory_cache_http_server.py#newcode31 tools/telemetry/telemetry/core/memory_cache_http_server.py:31: def handle(self): On 2014/07/11 20:12:58, tonyg wrote: > This ...
6 years, 5 months ago (2014-07-11 20:17:34 UTC) #2
tonyg
On 2014/07/11 20:17:34, dtu wrote: > https://codereview.chromium.org/386963006/diff/1/tools/telemetry/telemetry/core/memory_cache_http_server.py > File tools/telemetry/telemetry/core/memory_cache_http_server.py (right): > > https://codereview.chromium.org/386963006/diff/1/tools/telemetry/telemetry/core/memory_cache_http_server.py#newcode31 > ...
6 years, 5 months ago (2014-07-11 20:36:09 UTC) #3
tonyg
Friendly ping
6 years, 4 months ago (2014-07-28 15:53:30 UTC) #4
dtu
lgtm
6 years, 4 months ago (2014-07-29 19:02:11 UTC) #5
dtu
On 2014/07/29 19:02:11, dtu wrote: > lgtm Got a reason why it's BaseHTTPRequestHandler instead of ...
6 years, 4 months ago (2014-07-29 19:02:31 UTC) #6
tonyg
On 2014/07/29 19:02:31, dtu wrote: > On 2014/07/29 19:02:11, dtu wrote: > > lgtm > ...
6 years, 4 months ago (2014-07-29 19:04:47 UTC) #7
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-07-29 21:29:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/386963006/20001
6 years, 4 months ago (2014-07-29 21:31:11 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-30 03:24:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 04:39:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/1251)
6 years, 4 months ago (2014-07-30 04:39:09 UTC) #12
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-14 04:13:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/386963006/20001
6 years, 4 months ago (2014-08-14 04:18:13 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 06:26:34 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 06:31:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/3063) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/6827)
6 years, 4 months ago (2014-08-14 06:31:08 UTC) #17
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-20 18:27:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/386963006/40001
6 years, 4 months ago (2014-08-20 18:28:51 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 21:58:15 UTC) #20
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 23:39:56 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290948

Powered by Google App Engine
This is Rietveld 408576698