[WIP][NotForLand] IDL dictionary support

Source/bindings/tests/results/V8TestDictionary.cpp

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
+
+#include "config.h"
+#include "V8TestDictionary.h"
+
+#include "bindings/core/v8/Dictionary.h"
+#include "bindings/tests/v8/V8Node.h"
+#include "bindings/tests/v8/V8TestInterface.h"
+
+namespace WebCore {
+
+TestDictionary* V8TestDictionary::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value)

[haraken, 2014/07/21 16:11:59]

I'd rename this to toNative().

toNativeWithTypeCheck() is expected to return 0 if |v8Value| is a value of wrong
type. So the difference between toNative() and toNativeWithTypeCheck() should be
whether we check if(v8Value.IsEmpty() || !v8Value->IsObject()) or not.
toNative() should not have the check, and toNativeWithTypeCheck() should have
the check.

[bashi, 2014/07/22 02:33:58]

Thank you for the explanation. I was wondering I should use toNative() or
toNativeWithTypeCheck(). Renamed, but I want to confirm that we call this
toNative() even if its properties can come from toNativeWithTypeCheck()? suppose
we have a following definition:

 dictionary A {
   Node nodeMember;
 };

We will call V8Node::toNativeWithTypeCheck() for nodeMember (in DictionaryHelper
for now).

[haraken, 2014/07/22 04:30:10]

Understood, then we can probably:

- Add the if(v8Value.IsEmpty() || !v8Value->IsObject()) check to this method.
- Name this method toNativeWithTypeCheck().
- Don't define toNative().

What do you think?

[bashi, 2014/07/22 05:57:35]

I think this method should be toNative() because it is convenient if method
never returns 0. When a toNativeWithTypeCheck() call fails for a member, we can
either:
- return an empty dictionary object(all members are considered as undefined or
null), or
- ignore the conversion error (the member is considered as undefined or null)

The latter is easy to implement. The former can be more safety? (I'm not sure).

[haraken, 2014/07/22 07:23:19]

Makes sense; I agree that we keep the current implementation and call it
toNative().

+{
+    TestDictionary* impl = TestDictionary::create();
+    // FIXME: Do not use Dictionary and DictionaryHelper
+    Dictionary dictionary(v8Value, isolate);
+    impl->m_hasBooleanMember = DictionaryHelper::get(dictionary, "booleanMember", impl->m_booleanMember);
+    impl->m_hasLongMember = DictionaryHelper::get(dictionary, "longMember", impl->m_longMember);
+    if (!impl->m_hasLongMember)
+        impl->setLongMember(1);
+    impl->m_hasNodeMember = DictionaryHelper::get(dictionary, "nodeMember", impl->m_nodeMember);
+    impl->m_hasStringMember = DictionaryHelper::get(dictionary, "stringMember", impl->m_stringMember);
+    impl->m_hasTestInterfaceMember = DictionaryHelper::get(dictionary, "testInterfaceMember", impl->m_testInterfaceMember);
+    return impl;
+}
+
+v8::Handle<v8::Value> toV8(TestDictionary* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+    v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
+    if (impl->hasBooleanMember())
+        v8Object->Set(v8String(isolate, "booleanMember"), v8Boolean(impl->booleanMember(), isolate));
+
+    if (impl->hasLongMember())
+        v8Object->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, impl->longMember()));
+    else
+        v8Object->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, 1));
+
+    if (impl->hasNodeMember())
+        v8Object->Set(v8String(isolate, "nodeMember"), toV8(impl->nodeMember(), creationContext, isolate));
+
+    if (impl->hasStringMember())
+        v8Object->Set(v8String(isolate, "stringMember"), v8String(isolate, impl->stringMember()));
+
+    if (impl->hasTestInterfaceMember())
+        v8Object->Set(v8String(isolate, "testInterfaceMember"), toV8(impl->testInterfaceMember(), creationContext, isolate));
+
+    return v8Object;
+}
+
+} // namespace WebCore