Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 386943009: Navigation transitions: Expose navigation transitions feature to WebRuntimeFeatures. (Closed)

Created:
6 years, 5 months ago by shatch
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Navigation transitions: Expose navigation transitions feature to WebRuntimeFeatures. Thought it would be nice to keep this feature behind the experimental flag, but be able to turn it on via a finch trial from chrome. Will be followed by: https://codereview.chromium.org/389583004/ Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shatch
6 years, 5 months ago (2014-07-21 16:42:04 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-21 17:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/386943009/1
6 years, 5 months ago (2014-07-21 17:31:22 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 18:40:38 UTC) #4
Message was sent while issue was closed.
Change committed as 178575

Powered by Google App Engine
This is Rietveld 408576698