build/secondary/tools/grit/grit_rule.gni - Issue 386943006: Pull buildtools to get GN r282653

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 386943006: Pull buildtools to get GN r282653 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/tools/grit/grit_rule.gni

diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni

index a9745b444a43170b95f3549cb840e25342f04be2..078f334f72f77a1b9c35603f4204f4818ed79caa 100644

--- a/build/secondary/tools/grit/grit_rule.gni

+++ b/build/secondary/tools/grit/grit_rule.gni

@@ -187,9 +187,9 @@ template("grit") {

grit_flags,

"list lines")

- # The inputs are relative to the current (build) directory, rebase to

- # the current one.

- grit_outputs = rebase_path(grit_outputs_build_rel, ".", root_build_dir)

+ # The inputs are relative to the current (build) directory, make absolute.

awong 2014/07/11 19:52:20 Can you explain why abspath is required?

+ grit_outputs = get_path_info(

+ rebase_path(grit_outputs_build_rel, ".", root_build_dir), "abspath")

# The config and the action below get this visibility son only the generated

# source set can depend on them. The variable "target_name" will get

« no previous file with comments | « DEPS ('k') | components/autofill/content/browser/BUILD.gn » ('j') | no next file with comments »