[BuildBreak] Linux: Fix g++ 4.8 compilation for error: multi-line comment [-Werror=comment]

[BuildBreak] Linux: Fix g++ 4.8 compilation for error: multi-line comment [-Werror=comment]

While compling on linux with g++ 4.8, the file chrome/test/ppapi/ppapi_browsertest.cc is throwing

../../chrome/test/ppapi/ppapi_browsertest.cc:452:1: error: multi-line comment [-Werror=comment]
cc1plus: all warnings being treated as errors

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282597

[vivekg, 2014-07-11 08:47:59]

PTAL, thank you!

@thakis, is this something that should also be enabled while using clang as
default toolchain on linux?

[yhirano1, 2014-07-11 09:13:47]

lgtm, thanks

[vivekg, 2014-07-11 09:14:13]

The CQ bit was checked by vivekg@chromium.org

[yhirano, 2014-07-11 09:14:14]

lgtm

[commit-bot: I haz the power, 2014-07-11 09:14:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/386933002/1

[vivekg, 2014-07-11 09:15:28]

The CQ bit was unchecked by vivekg@chromium.org

[vivekg, 2014-07-11 09:15:42]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-11 09:15:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/386933002/1

[commit-bot: I haz the power, 2014-07-11 09:36:11]

Change committed as 282597

[Nico, 2014-07-12 19:02:59]

On Fri, Jul 11, 2014 at 1:47 AM, <vivekg@chromium.org> wrote:

> PTAL, thank you!
>

Thank you for the fix!


> @thakis, is this something that should also be enabled while using clang as
> default toolchain on linux?
>

My understand was that it should already be enabled. Clang has a -Wcomment,
and it seems to work:

$ cat test.cc
//      LIST_TEST(URLLoader_UntrustedHttpRequests) \

int a;
$ clang -Wall test.cc -c
test.cc:1:52: warning: multi-line // comment [-Wcomment]
//      LIST_TEST(URLLoader_UntrustedHttpRequests) \
                                                   ^
1 warning generated.

I checked that we do build browser_tests with -Wall. So I'm not sure why
our bots didn't catch this. Maybe you can try reverting this locally and
check if clang catches it, and if not, make a reduced test case and send
that to me?

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.