Issue 386893004: Update speedometer to use results.AddValue

Issue 386893004: Update speedometer to use results.AddValue (Closed)

Created:
6 years, 5 months ago by nednguyen

Modified:
6 years, 5 months ago

Reviewers:
nduca

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update speedometer to use results.AddValue BUG=391943 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282750

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tools/perf/benchmarks/speedometer.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/386893004/1

6 years, 5 months ago (2014-07-11 16:02:35 UTC) #2

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-11 19:39:07 UTC) #3

tonyg

6 years, 5 months ago (2014-07-12 02:26:58 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/387953006/ by tonyg@chromium.org.

The reason for reverting is: Breaks speedometer. Should be a ListOfScalarValues.

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:62
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/benchmarks/speedometer.py:36
    tab.EvaluateJavaScript('benchmarkClient._timeValues')))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError

Locals:
  important : True
  name      : 'Total'
  page      : <telemetry.page.page.Page object at 0x1d6e590>
  units     : 'ms'
  value     : [13237.9869999991, 13351.2720000012, 14052.7640000023,
14136.3950000013, 13685.9580000001, 14048.2879999999, 14010.3279999989,
13941.6210000018, 14087.0519999998, 13388.6279999983].

Expand Messages | Collapse Messages