Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 386893003: [Preferences] Change a preference from Integer to String (Closed)

Created:
6 years, 5 months ago by Mathieu
Modified:
6 years, 5 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Preferences] Change a preference from Integer to String kContextualSearchEnabled should be a string instead of an integer, to be consistent with the calling code. This pref was never set (ever!) on people's profiles, only registered in profile.cc. I verified with gab@ that moving to String at this point will not mess things up. BUG=341761 R=noms@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282667

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/profiles/profile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mathieu
Hi Monica, Can you have a look?
6 years, 5 months ago (2014-07-11 15:48:54 UTC) #1
noms (inactive)
profiles lgtm with a nit for hilarity. :) https://codereview.chromium.org/386893003/diff/1/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): https://codereview.chromium.org/386893003/diff/1/chrome/common/pref_names.cc#newcode331 chrome/common/pref_names.cc:331: // ...
6 years, 5 months ago (2014-07-11 15:56:12 UTC) #2
Mathieu
thanks :) https://codereview.chromium.org/386893003/diff/1/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): https://codereview.chromium.org/386893003/diff/1/chrome/common/pref_names.cc#newcode331 chrome/common/pref_names.cc:331: // "true" - opt-in (enabled)" On 2014/07/11 ...
6 years, 5 months ago (2014-07-11 16:02:16 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-11 16:02:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/386893003/20001
6 years, 5 months ago (2014-07-11 16:04:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 19:18:51 UTC) #6
Mathieu
6 years, 5 months ago (2014-07-11 19:43:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r282667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698