Converted IDBVersionChangeEvent.dataLoss to an enumeration: IDBDataLossAmount

Source/modules/indexeddb/IDBVersionChangeEvent.cpp

Index: Source/modules/indexeddb/IDBVersionChangeEvent.cpp
diff --git a/Source/modules/indexeddb/IDBVersionChangeEvent.cpp b/Source/modules/indexeddb/IDBVersionChangeEvent.cpp
index e55fdfca2febe05a495a1d15b9a8b6c59ba666f5..a4ac5b06eba04b973f94f882c6fe34cbd898fb0b 100644
--- a/Source/modules/indexeddb/IDBVersionChangeEvent.cpp
+++ b/Source/modules/indexeddb/IDBVersionChangeEvent.cpp
@@ -26,8 +26,6 @@
 #include "config.h"
 #include "modules/indexeddb/IDBVersionChangeEvent.h"
 
-#include "bindings/modules/v8/IDBBindingUtilities.h"
-
 namespace WebCore {
 
 
@@ -58,6 +56,12 @@ IDBVersionChangeEvent::IDBVersionChangeEvent(const AtomicString& eventType, cons
     , m_newVersion(initializer.newVersion)
     , m_dataLoss(blink::WebIDBDataLossNone)
 {
+    if (initializer.dataLoss.isEmpty() || initializer.dataLoss == "none")
+        m_dataLoss = blink::WebIDBDataLossNone;
+    else if (initializer.dataLoss == "total")
+        m_dataLoss = blink::WebIDBDataLossTotal;
+    else
+        ASSERT_NOT_REACHED(); // Should have been validated by the bindings

[jsbell, 2014/07/16 22:48:36]

Is this actually enforced by the bindings now? (I didn't think we quite had
Dictionary/enum support together - if so, awesome!)

Can you add in a test case that passes an invalid value and ensure the event
constructor throws?

[bashi, 2014/07/17 01:47:57]

IIUC, the bindings checks whether the value is valid.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[cmumford, 2014/07/17 17:14:24]

Not checked - That's my follow-up change (crbug.com/358067). I've removed the
assertion, and will re-add it later.

     ScriptWrappable::init(this);
 }