Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 386873002: Reland "Use upstream libaddressinput in Chrome." (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reland "Use upstream libaddressinput in Chrome." Remove static initializer and reland https://crrev.com/282408 which was reverted in https://crrev.com/282426. TBR=estade@chromium.org,thestig@chromium.org BUG=389918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282726

Patch Set 1 #

Patch Set 2 : Fix compile. #

Patch Set 3 : Fix iOS compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2262 lines, -1749 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/ios/grit_whitelist.txt View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/app/address_input_strings.grdp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 6 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 9 chunks +34 lines, -31 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 5 chunks +12 lines, -17 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_i18n_input.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc View 5 chunks +20 lines, -12 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/country_combobox_model.cc View 3 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/country_combobox_model_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/autofill/mock_address_validator.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 4 chunks +19 lines, -8 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +1 line, -6 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address_i18n.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_country_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 3 chunks +67 lines, -96 lines 0 comments Download
M third_party/libaddressinput/README.chromium View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/libaddressinput/chromium/addressinput_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/libaddressinput/chromium/addressinput_util.cc View 3 chunks +16 lines, -18 lines 0 comments Download
M third_party/libaddressinput/chromium/addressinput_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/libaddressinput/chromium/chrome_address_validator.h View 6 chunks +73 lines, -28 lines 0 comments Download
A third_party/libaddressinput/chromium/chrome_address_validator.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A + third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc View 17 chunks +284 lines, -156 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_downloader_impl.h View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_downloader_impl.cc View 3 chunks +28 lines, -24 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc View 3 chunks +16 lines, -12 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_rule_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.cc View 2 chunks +22 lines, -22 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A third_party/libaddressinput/chromium/fallback_data_store.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + third_party/libaddressinput/chromium/fallback_data_store.cc View 2 chunks +9 lines, -18 lines 0 comments Download
A third_party/libaddressinput/chromium/fallback_data_store_unittest.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/input_suggester.h View 1 chunk +133 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/input_suggester.cc View 1 chunk +521 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/json.cc View 1 2 chunks +98 lines, -74 lines 0 comments Download
A + third_party/libaddressinput/chromium/libaddressinput_util.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/libaddressinput/chromium/libaddressinput_util.cc View 3 chunks +19 lines, -22 lines 0 comments Download
A + third_party/libaddressinput/chromium/libaddressinput_util_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A third_party/libaddressinput/chromium/override/basictypes_override.h View 1 chunk +10 lines, -0 lines 0 comments Download
D third_party/libaddressinput/chromium/preload_address_validator.h View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/libaddressinput/chromium/preload_address_validator.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/libaddressinput/chromium/preload_address_validator_unittest.cc View 1 chunk +0 lines, -612 lines 0 comments Download
A third_party/libaddressinput/chromium/storage_test_runner.h View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/storage_test_runner.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/string_compare.cc View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/string_compare_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/trie.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/trie.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A + third_party/libaddressinput/chromium/trie_unittest.cc View 6 chunks +37 lines, -42 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 chunk +93 lines, -172 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
please use gerrit instead
FYI. (The static initializer is removed in libaddressinput r304.)
6 years, 5 months ago (2014-07-11 03:08:43 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-11 03:09:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/386873002/1
6 years, 5 months ago (2014-07-11 03:12:25 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 03:43:16 UTC) #4
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 5 months ago (2014-07-11 03:45:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 03:46:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/27604)
6 years, 5 months ago (2014-07-11 03:46:09 UTC) #7
roubert
The CQ bit was checked by roubert@google.com
6 years, 5 months ago (2014-07-11 13:29:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/386873002/1
6 years, 5 months ago (2014-07-11 13:30:57 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 13:58:32 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 14:01:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/27669)
6 years, 5 months ago (2014-07-11 14:01:22 UTC) #12
please use gerrit instead
I'm fixing the compile errors and relanding soon.
6 years, 5 months ago (2014-07-11 16:33:49 UTC) #13
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-11 19:16:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/386873002/20001
6 years, 5 months ago (2014-07-11 19:17:52 UTC) #15
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 5 months ago (2014-07-11 19:44:26 UTC) #16
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-11 19:49:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/386873002/40001
6 years, 5 months ago (2014-07-11 19:50:25 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 23:18:42 UTC) #19
Message was sent while issue was closed. 
Change committed as 282726

Powered by Google App Engine
This is Rietveld 408576698