Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: remoting/webapp/options_menu.js

Issue 386853002: Add a Record button to the web-app if the host supports video recording. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move code out into OptionsMenu and VideoFrameRecorder Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/options_menu.js
diff --git a/remoting/webapp/options_menu.js b/remoting/webapp/options_menu.js
index ca6d6156bc5f43436c5e95bb05151bacd2a3c50a..77be9a0d7d43d28f856b84121f4d71e7523e251a 100644
--- a/remoting/webapp/options_menu.js
+++ b/remoting/webapp/options_menu.js
@@ -23,13 +23,15 @@ var remoting = remoting || {};
*/
remoting.OptionsMenu = function(sendCtrlAltDel, sendPrtScrn,
resizeToClient, shrinkToFit,
- newConnection, fullscreen) {
+ newConnection, fullscreen,
+ startStopRecording) {
this.sendCtrlAltDel_ = sendCtrlAltDel;
this.sendPrtScrn_ = sendPrtScrn;
this.resizeToClient_ = resizeToClient;
this.shrinkToFit_ = shrinkToFit;
this.newConnection_ = newConnection;
this.fullscreen_ = fullscreen;
+ this.startStopRecording_ = startStopRecording;
/**
* @type {remoting.ClientSession}
* @private
@@ -50,6 +52,10 @@ remoting.OptionsMenu = function(sendCtrlAltDel, sendPrtScrn,
this.fullscreen_.addEventListener(
'click', this.onFullscreen_.bind(this), false);
}
+ if (this.startStopRecording_) {
+ this.startStopRecording_.addEventListener(
+ 'click', this.onStartStopRecording_.bind(this), false);
+ }
};
/**
@@ -70,6 +76,9 @@ remoting.OptionsMenu.prototype.onShow = function() {
remoting.MenuButton.select(
this.fullscreen_, remoting.fullscreen.isActive());
}
+ if (this.startStopRecording_) {
+ this.startStopRecording_.hidden = !this.clientSession_.canRecordVideo();
+ }
}
};
@@ -110,3 +119,9 @@ remoting.OptionsMenu.prototype.onNewConnection_ = function() {
remoting.OptionsMenu.prototype.onFullscreen_ = function() {
remoting.fullscreen.toggle();
};
+
+remoting.OptionsMenu.prototype.onStartStopRecording_ = function() {
+ if (this.clientSession_) {
+ this.clientSession_.startStopRecording();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698