Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 386803003: Be robust to printing too large pages in tests (Closed)

Created:
6 years, 5 months ago by enne (OOO)
Modified:
6 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, danakj
Project:
chromium
Visibility:
Public.

Description

Be robust to printing too large pages in tests Creating a canvas can fail, so be robust to this. BUG=392587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
This is crashing in clusterfuzz due to trying to print something that's 38k pages long. ...
6 years, 5 months ago (2014-07-10 22:53:58 UTC) #1
Dirk Pranke
rubber-stamp lgtm.
6 years, 5 months ago (2014-07-10 22:57:01 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 5 months ago (2014-07-10 22:57:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/386803003/1
6 years, 5 months ago (2014-07-10 23:00:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:58:52 UTC) #5
Message was sent while issue was closed.
Change committed as 282500

Powered by Google App Engine
This is Rietveld 408576698