Use SkBitmap::readPixels to perform copy to 4444.

Use SkBitmap::readPixels to perform copy to 4444.

readPixels allows specifying the rowBytes, which is important for
this caller, who wants them to be 4-byte aligned.

BUG=chromium:390782
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290367

[scroggo, 2014-07-22 13:55:12]

Brian, would you mind reviewing this since Mike's out?

[bsalomon, 2014-07-22 13:58:26]

lgtm

[scroggo, 2014-07-22 14:03:15]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-07-22 14:04:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scroggo@google.com/386743002/1

[commit-bot: I haz the power, 2014-07-22 14:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 14:04:44]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[scroggo, 2014-07-22 14:06:48]

Florin, you're a super star committer, right? Can you review this patch please?

[f(malita), 2014-07-22 14:09:13]

LGTM

On 2014/07/22 14:06:48, scroggo wrote:
> Florin, you're a super star committer, right? Can you review this patch
please?

I think you'll need a cc/ owner (which I'm not) for this one.

[scroggo, 2014-07-22 14:16:31]

enne@, can you give me an owners review (or point me to the right person to do
so)?

[enne (OOO), 2014-07-24 17:58:19]

lgtm if this fixes the bug in question

(Sorry about the review delay; thanks for the ping.)

https://codereview.chromium.org/386743002/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/386743002/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:114: dst_info.fColorType = dst_colorType;
This was here before you, but you can you make this chrome style and rename this
dst_colortype or dst_color_type?

[scroggo, 2014-07-24 18:11:38]

https://codereview.chromium.org/386743002/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/386743002/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:114: dst_info.fColorType = dst_colorType;
On 2014/07/24 17:58:18, enne wrote:
> This was here before you, but you can you make this chrome style and rename
this
> dst_colortype or dst_color_type?

Done.

[scroggo, 2014-07-24 18:11:42]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-07-24 18:14:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scroggo@google.com/386743002/20001

[commit-bot: I haz the power, 2014-07-24 21:33:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-24 22:14:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 22:14:11]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[Feng Qian, 2014-08-18 19:57:05]

The CQ bit was checked by feng@chromium.org

[Feng Qian, 2014-08-18 19:57:11]

The CQ bit was unchecked by feng@chromium.org

[Feng Qian, 2014-08-18 19:59:27]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-08-18 20:00:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scroggo@google.com/386743002/20001

[commit-bot: I haz the power, 2014-08-18 21:53:25]

Committed patchset #2 (20001) as 290367