Issue 386733002: Only build extensions code in chrome/browser/ui when extensions are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 386733002: Only build extensions code in chrome/browser/ui when extensions are enabled. (Closed)

Created:
6 years, 5 months ago by Lei Zhang

Modified:
6 years, 5 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, eroman, mmenke, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Only build extensions code in chrome/browser/ui when extensions are enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282492

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -30 lines)			Patch
M	chrome/browser/extensions/extension_system_impl.cc	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/off_the_record_profile_impl.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/net_internals/net_internals_ui.cc	View	6 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	4 chunks	+24 lines, -19 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/386733002/20001

6 years, 5 months ago (2014-07-10 23:58:35 UTC) #4

Message was sent while issue was closed.

Change committed as 282492