Issue 386663003: Zero out temporary arrays before use in PDF encryption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 386663003: Zero out temporary arrays before use in PDF encryption. (Closed)

Created:
6 years, 5 months ago by Bo Xu

Modified:
6 years, 5 months ago

Reviewers:
palmer

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Zero out temporary arrays before use in PDF encryption. BUG=387834 R=palmer@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d5a0e7a

Patch Set 2 : Use sizeof #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

palmer

LGTM after you switch to sizeof(...). https://codereview.chromium.org/386663003/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp (right): https://codereview.chromium.org/386663003/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp#newcode470 core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp:470: FXSYS_memset32(tempkey, 0, 32); ...

6 years, 5 months ago (2014-07-10 18:27:32 UTC) #2

Bo Xu

https://codereview.chromium.org/386663003/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp (right): https://codereview.chromium.org/386663003/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp#newcode470 core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp:470: FXSYS_memset32(tempkey, 0, 32); On 2014/07/10 18:27:32, Chromium Palmer wrote: ...

6 years, 5 months ago (2014-07-10 18:46:42 UTC) #3

Bo Xu

6 years, 5 months ago (2014-07-10 18:50:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as rd5a0e7a (presubmit successful).

Expand Messages | Collapse Messages

Issue 386663003: Zero out temporary arrays before use in PDF encryption. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use sizeof #

Messages