Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 386643003: Enrollment recovery: Fix check for presence of machine id. (Closed)

Created:
6 years, 5 months ago by Thiemo Nagel
Modified:
6 years, 5 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enrollment recovery: Fix check for presence of machine id. Ensure that enrollment recovery really only is triggered when the machine id can be accessed. BUG=389481 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282484

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Hi Julian, there was a mistake in the logic which decides whether enrollment recovery is ...
6 years, 5 months ago (2014-07-10 18:02:34 UTC) #1
pastarmovj
lgtm
6 years, 5 months ago (2014-07-10 18:36:33 UTC) #2
Thiemo Nagel
On 2014/07/10 18:36:33, pastarmovj wrote: > lgtm Much appreciated, thank you!
6 years, 5 months ago (2014-07-10 18:41:27 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 5 months ago (2014-07-10 19:22:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/386643003/20001
6 years, 5 months ago (2014-07-10 19:23:30 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:03:12 UTC) #6
Message was sent while issue was closed.
Change committed as 282484

Powered by Google App Engine
This is Rietveld 408576698