kiosk: Retry failed app data fetch.

chrome/browser/extensions/webstore_data_fetcher.cc

Index: chrome/browser/extensions/webstore_data_fetcher.cc
diff --git a/chrome/browser/extensions/webstore_data_fetcher.cc b/chrome/browser/extensions/webstore_data_fetcher.cc
index 89d523b8135dc93f80fecf59adce350bffb011d3..4eec712060e9fa1658d882768599ff9afebcfede 100644
--- a/chrome/browser/extensions/webstore_data_fetcher.cc
+++ b/chrome/browser/extensions/webstore_data_fetcher.cc
@@ -29,7 +29,8 @@ WebstoreDataFetcher::WebstoreDataFetcher(
     : delegate_(delegate),
       request_context_(request_context),
       referrer_url_(referrer_url),
-      id_(webstore_item_id) {
+      id_(webstore_item_id),
+      max_auto_retries_(0) {
 }
 
 WebstoreDataFetcher::~WebstoreDataFetcher() {}
@@ -43,6 +44,9 @@ void WebstoreDataFetcher::Start() {
   webstore_data_url_fetcher_->SetReferrer(referrer_url_.spec());
   webstore_data_url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |
                                            net::LOAD_DISABLE_CACHE);
+  webstore_data_url_fetcher_->SetMaxRetriesOn5xx(max_auto_retries_);

[asargent_no_longer_on_chrome, 2014/07/10 23:08:34]

Should you only call this if max_auto_retries_ is > 0?

[xiyuan, 2014/07/10 23:23:13]

The code assumes that the default retry numbers in URLFetcher are 0 (which is
currently the case) and this is a no-op when |max_auto_retries_| is 0.

Do you feel this assumes too much implementation details and we should wrap it
with the suggested "if"?

[asargent_no_longer_on_chrome, 2014/07/10 23:49:06]

Yeah, I'm not sure. The URLFetcher header comments don't really make this clear,
so I was thinking that we might want to just take whatever the default behavior
is (which is currently 0, but could conceivably change some day?) unless our own
consumer wanted to change it to something else. I don't think it's a really a
big deal either way though, so use your best judgement. 

[xiyuan, 2014/07/11 04:05:44]

Okay. Think it makes more sense than assuming the default is no retry.

I have added the "if" so that we use the URLFetcher default behavior on 0 and
updated the comment in header file.

+  webstore_data_url_fetcher_->SetAutomaticallyRetryOnNetworkChanges(
+      max_auto_retries_);
   webstore_data_url_fetcher_->Start();
 }