Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: Source/bindings/tests/results/V8TestException.cpp

Issue 386613002: FYI: Compile fixes when always using a local for method return value Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestException.h" 8 #include "V8TestException.h"
9 9
10 #include "bindings/core/v8/ExceptionState.h" 10 #include "bindings/core/v8/ExceptionState.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 static void readonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String> , const v8::PropertyCallbackInfo<v8::Value>& info) 66 static void readonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String> , const v8::PropertyCallbackInfo<v8::Value>& info)
67 { 67 {
68 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter"); 68 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
69 TestExceptionV8Internal::readonlyStringAttributeAttributeGetter(info); 69 TestExceptionV8Internal::readonlyStringAttributeAttributeGetter(info);
70 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 70 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
71 } 71 }
72 72
73 static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info) 73 static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
74 { 74 {
75 TestException* impl = V8TestException::toNative(info.Holder()); 75 TestException* impl = V8TestException::toNative(info.Holder());
76 v8SetReturnValueString(info, impl->toString(), info.GetIsolate()); 76 String result = impl->toString();
77 v8SetReturnValueString(info, result, info.GetIsolate());
77 } 78 }
78 79
79 static void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& in fo) 80 static void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& in fo)
80 { 81 {
81 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod"); 82 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
82 TestExceptionV8Internal::toStringMethod(info); 83 TestExceptionV8Internal::toStringMethod(info);
83 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 84 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
84 } 85 }
85 86
86 } // namespace TestExceptionV8Internal 87 } // namespace TestExceptionV8Internal
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 fromInternalPointer(object)->deref(); 168 fromInternalPointer(object)->deref();
168 } 169 }
169 170
170 template<> 171 template<>
171 v8::Handle<v8::Value> toV8NoInline(TestException* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate) 172 v8::Handle<v8::Value> toV8NoInline(TestException* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate)
172 { 173 {
173 return toV8(impl, creationContext, isolate); 174 return toV8(impl, creationContext, isolate);
174 } 175 }
175 176
176 } // namespace WebCore 177 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698