Issue 386603003: Fix Windows compile error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 386603003: Fix Windows compile error. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)

Modified:
6 years, 5 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix Windows compile error. BUG= R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22326

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/spaces.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/spaces.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm with a comment https://codereview.chromium.org/386603003/diff/1/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/386603003/diff/1/src/spaces.cc#newcode2588 src/spaces.cc:2588: if (free_chunk >= static_cast<intptr_t>(size_in_bytes)) { ...

6 years, 5 months ago (2014-07-10 14:38:44 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/386603003/diff/1/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/386603003/diff/1/src/spaces.cc#newcode2588 src/spaces.cc:2588: if (free_chunk >= static_cast<intptr_t>(size_in_bytes)) { On 2014/07/10 14:38:44, Dmitry ...

6 years, 5 months ago (2014-07-10 14:49:53 UTC) #3

Hannes Payer (out of office)

6 years, 5 months ago (2014-07-10 14:50:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22326 (tree was closed).

Expand Messages | Collapse Messages

Issue 386603003: Fix Windows compile error. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages